Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to have mapping rule without a join condition #1938

Closed
benedeki opened this issue Oct 1, 2021 · 1 comment · Fixed by #1970
Closed

Make it possible to have mapping rule without a join condition #1938

benedeki opened this issue Oct 1, 2021 · 1 comment · Fixed by #1970
Assignees
@dk1844
Labels
Conformance Conformance Job affected feature New feature Menas Menas component affected priority: medium Important but not urgent UX Something concerning UX

Comments

@benedeki
Copy link
Collaborator

benedeki commented Oct 1, 2021

Background

With the ability of filtering it is possible the mapping table is reduced enough, and there's no need to add a join condition.

Feature

Make it possible to have no join condition on the Mapping Conformance Rule - support must exist both on back-end and front-end.
@benedeki benedeki added feature New feature Menas Menas component affected Conformance Conformance Job affected UX Something concerning UX priority: medium Important but not urgent labels Oct 1, 2021
@Zejnilovic Zejnilovic mentioned this issue Oct 1, 2021
Closed
@dk1844 dk1844 mentioned this issue Nov 3, 2021
Merged
@dk1844 dk1844 linked a pull request Nov 4, 2021 that will close this issue
1938 MappingCR without join a condition #1970
Merged
@dk1844
Copy link
Contributor

dk1844 commented Nov 5, 2021

Release notes
Mapping Conformance Rule may now exist without a join conditions, but in such a case a non-empty filter must be defined instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk1844 dk1844

Labels
Conformance Conformance Job affected feature New feature Menas Menas component affected priority: medium Important but not urgent UX Something concerning UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1938 MappingCR without join a condition AbsaOSS/enceladus
2 participants
@dk1844 @benedeki