Split connection state machines files #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
changed the title
Patrik-Stas
changed the title
mirgee
reviewed
Sep 25, 2020
Patrik-Stas
force-pushed
the
v3/restructure-files
branch
2 times, most recently
from
57b6ed0
to
3003985
Compare
mirgee
reviewed
Sep 28, 2020
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
v3/restructure-files
branch
from
3003985
to
6b2d424
Compare
* Split connection state machines files Signed-off-by: Patrik Stas <patrik.stas@absa.africa> * Inviter conn should also check bootstrap agent for messages. Refactor. Signed-off-by: Patrik Stas <patrik.stas@absa.africa> * Connection.connect returns invitation for inviter. Refactor Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
v3/restructure-files
branch
from
05f08be
to
a13a945
Compare
mirgee
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DidExchangeStateSMstate machine into 2 separate state machines for inviter and inviteeagent info, updated to3.0serialization formatv3/handlers/connection/connection.rsserves as proxy interface to preserve shared inviter/invitee interface.get_invite_details. It returns connection invitation only if called on inviter connection in stateInvited. Otherwise returns error. Previously the code was attempting to construct invitation object from DDO of connection counterparty known at the moment.connect()on connection now returns connection invitation if the connection is inviter, otherwise returns string{}Signed-off-by: Patrik Stas patrik.stas@absa.africa