Add local revocation integration test #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
mirgee
force-pushed
the
tests/batch-rev
branch
from
1ecdeaa
to
9057d08
Compare
Patrik-Stas
reviewed
Sep 30, 2020
libvcx/src/lib.rs
Outdated
|
|
||
| let institution_did = settings::get_config_value(settings::CONFIG_INSTITUTION_DID).unwrap(); | ||
| let (faber, alice) = ::connection::tests::create_connected_connections(); | ||
| let (schema_id, cred_def_id, rev_reg_id, _cred_def_handle, credential_offer) = _issue_address_credential(faber, alice, &institution_did); |
There was a problem hiding this comment.
The fact that the last element is credential handle but it is called credential_offer is bit confusing
There was a problem hiding this comment.
Also in the _issue_address_credential function itself
Patrik-Stas
reviewed
Sep 30, 2020
| ::issuer_credential::revoke_credential(issuer_handle).unwrap(); | ||
| let (_, delta_after_revoke, _) = ::utils::libindy::anoncreds::get_rev_reg_delta_json(&rev_reg_id.unwrap(), Some(timestamp + 1), None).unwrap(); | ||
| assert_ne!(delta, delta_after_revoke); | ||
| } | ||
|
|
||
| fn revoke_credential_local(issuer_handle: u32, rev_reg_id: Option<String>) { |
There was a problem hiding this comment.
I think it'd be better if this function only takes issuer_handle as parameter and gets rev_reg_id from credential itself, even if it means adding new getter on issuer credential
mirgee
force-pushed
the
tests/batch-rev
branch
from
90f2401
to
df567be
Compare
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
mirgee
force-pushed
the
tests/batch-rev
branch
from
df567be
to
8303c75
Compare
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com> # Conflicts: # libvcx/src/connection.rs
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com