Node wrapper aries testing #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
commented
Aug 21, 2020
mirgee
requested changes
Aug 24, 2020
Patrik-Stas
force-pushed
the
node-aries-testing
branch
2 times, most recently
from
f156087
to
16f0e0c
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
node-aries-testing
branch
from
16f0e0c
to
107d567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy tests were relying on passing
ENABLE_TEST_MODEwhen callingvcx_init, which would pre-set libvcx into testing mode with mocked enabled.Instead of doing that, tests are passing their own desired configuration now
The tests are now specifying they want to run with
3.0protocol_type (let's move it to4.0in next step)Some tests are disabled. Especially those which are relying on some agency
1.0mock responses. These responses are currently hardcoded in libvcx, so internals must be changed / or testing approach, before these tests are enabled again.Some tests were easy enough to migrate from legacy to Aries (for example test checking generating connection invitation)
Additionally fixes issue with vcx node wrapper
suite3logging tests (we were not running these tests and I think it's been probably failing since switch to different ffi packages). The fix is done inwrappers/node/src/api/logging.ts