-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to 3.0 and 4.0 protocol_type #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
commented
Aug 26, 2020
@@ -1353,37 +1358,38 @@ pub mod tests { | |||
|
|||
pub fn create_connected_connections() -> (u32, u32) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used only be tests agency_pool_tests
tests. Those tests are still not passing due to some issues, however this is their shared step and changes in this PR fixes run of create_connected_connections
. Previously this method assumed legacy connections
Cleanup/tests iter1
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Migrate connections API tests to Aries
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Remove connection redirect
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Fix linter warnings
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Fix failing connection tests, cleanup
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
…request_can_be_retried Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Patrik-Stas
added
the
changelog-excluded
Work which should not be included in release changelog.
label
Sep 9, 2020
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Cleanup vcx, utils, proof
Patrik-Stas
changed the title
Run only tests not using v1 connections, v1 onboarding
Migrate tests to 3.0 and 4.0 protocols
Sep 14, 2020
Patrik-Stas
changed the title
Migrate tests to 3.0 and 4.0 protocols
Migrate tests to 3.0 and 4.0 protocol_type
Sep 14, 2020
Patrik-Stas
added
changelog-excluded
Work which should not be included in release changelog.
and removed
changelog-excluded
Work which should not be included in release changelog.
labels
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISALLOW_V1
. If set totrue
, code will panic on attempt to create v1 connection or to use onboarding v1CONFIG_PROTOCOL_TYPE
- to override protocol type (useful when working on migration ofa test from v1 to aries)
connect_register_provision
prints libvcx settings.agency_pool_tests
feature to separate tests which require bothpool
andagency
.Contains PR #66
update_agent_info
- this was setting COM_METHOD on agency, we don't use this. We are usingupdate_webhook_url
download_agent_messages
- is different fromdownload_messages
. The download_agent_messages was trying to download sent messages from agency - this was valid use case only on v1 agency, not with aries anymore.also delete redirection test to reduce noise, we won't be supporting that, it's also legacy
test_update_agent_webhook_real
and activated it. I know we should maybe fetch the value from agency and compare it, but let's leave that for next phase. Let's just do necessary to get those tests passing now.test test_download_agent_messages
- was testingdownload_agent_messages
feature which only applies to V1 agency.test_send_and_download_messages
which tests downloading received messages.