Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to 3.0 and 4.0 protocol_type #65

Merged
merged 33 commits into from
Sep 15, 2020
Merged

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Aug 26, 2020

  • Reads environment variable DISALLOW_V1 . If set to true, code will panic on attempt to create v1 connection or to use onboarding v1
  • Defaults to protocol V3
  • Read environment variable CONFIG_PROTOCOL_TYPE - to override protocol type (useful when working on migration of
    a test from v1 to aries)
  • When running in test mode, connect_register_provision prints libvcx settings.
  • Uses agency_pool_tests feature to separate tests which require both pool and agency.

Contains PR #66

  • removes support for update_agent_info - this was setting COM_METHOD on agency, we don't use this. We are using update_webhook_url
  • removes support for download_agent_messages - is different from download_messages. The download_agent_messages was trying to download sent messages from agency - this was valid use case only on v1 agency, not with aries anymore.
    also delete redirection test to reduce noise, we won't be supporting that, it's also legacy
  • turned test test_update_agent_info_real into test_update_agent_webhook_real and activated it. I know we should maybe fetch the value from agency and compare it, but let's leave that for next phase. Let's just do necessary to get those tests passing now.
  • remove test test_download_agent_messages - was testing download_agent_messages feature which only applies to V1 agency.
  • the removed test was replaced by test_send_and_download_messages which tests downloading received messages.

@@ -1353,37 +1358,38 @@ pub mod tests {

pub fn create_connected_connections() -> (u32, u32) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used only be tests agency_pool_tests tests. Those tests are still not passing due to some issues, however this is their shared step and changes in this PR fixes run of create_connected_connections. Previously this method assumed legacy connections

Patrik-Stas and others added 25 commits August 26, 2020 18:02
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
mirgee and others added 3 commits September 6, 2020 20:49
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
…request_can_be_retried

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas added the changelog-excluded Work which should not be included in release changelog. label Sep 9, 2020
@Patrik-Stas Patrik-Stas changed the title Run only tests not using v1 connections, v1 onboarding Migrate tests to 3.0 and 4.0 protocols Sep 14, 2020
@Patrik-Stas Patrik-Stas changed the title Migrate tests to 3.0 and 4.0 protocols Migrate tests to 3.0 and 4.0 protocol_type Sep 14, 2020
@Patrik-Stas Patrik-Stas added changelog-excluded Work which should not be included in release changelog. and removed changelog-excluded Work which should not be included in release changelog. labels Sep 15, 2020
@Patrik-Stas Patrik-Stas merged commit 6a80905 into master Sep 15, 2020
@Patrik-Stas Patrik-Stas deleted the cleanup/tests branch September 15, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants