Restore messaging tests #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirgee
requested changes
Sep 20, 2020
| let hello_msg = download_messages(None, None, Some(vec![hello_uid])).unwrap(); | ||
| assert_eq!(hello_msg[0].msgs[0].decrypted_payload, Some("{\"@type\":{\"name\":\"hello\",\"ver\":\"1.0\",\"fmt\":\"json\"},\"@msg\":\"hello\"}".to_string())); | ||
|
|
||
| // Agency returns a bad request response for invalid dids |
There was a problem hiding this comment.
Does this require changes on agency side?
There was a problem hiding this comment.
Node agency is currently not performing did validation, it just tries to match the did. We should probably audit agency inputs and probably think about its error reporting in general...
Patrik-Stas
force-pushed
the
restore/agency_pool_tests
branch
from
3bae3f5
to
bcf93af
Compare
Patrik-Stas
changed the title
Patrik-Stas
force-pushed
the
restore/agency_pool_tests
branch
from
90633e4
to
ebece4c
Compare
Patrik-Stas
force-pushed
the
restore/agency_pool_tests
branch
from
cc0aa07
to
6391fb1
Compare
mirgee
previously approved these changes
Sep 22, 2020
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
…sages_response Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
…dMessageBuilder) Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
restore/agency_pool_tests
branch
from
452e82c
to
d946da0
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
restore/agency_pool_tests
branch
from
d946da0
to
f4f9084
Compare
mirgee
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrik Stas patrik.stas@absa.africa