Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring - Scripts bug fixes #10

Open
Tracked by #3
miroslavpojer opened this issue May 21, 2024 · 0 comments
Open
Tracked by #3

Refactoring - Scripts bug fixes #10

miroslavpojer opened this issue May 21, 2024 · 0 comments

Comments

@miroslavpojer
Copy link
Collaborator

miroslavpojer commented May 21, 2024

output_file_path = f"{output_directory}/{output_file_name}"

it makes your code less multiplatform - this can't run on Windows because of different path delimiters. Better is to use

os.path.join function
  • Be careful about variable scopes. For example, in github_query_project_state.py, session = requests.Session() - the session is not passed to any function below that code, but it's used within function send_graphql_query directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant