Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failover demo #103

Merged
merged 1 commit into from Apr 27, 2020
Merged

Failover demo #103

merged 1 commit into from Apr 27, 2020

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Apr 27, 2020

Update README.md - minor update Round Robin demo

Update README.md - alter Failover demo

Update Makefile - alter test API

Resolves #69

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is some advanced usage of GNU make, pretty cool! Please consider couple of amendments, otherwise looks great.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Update README.md - minor update Round Robin demo

Update README.md - alter Failover demo

Update Makefile - alter test API
@kuritka kuritka requested a review from ytsarev April 27, 2020 16:36
@ytsarev ytsarev changed the title Failover demo (#69) Failover demo Apr 27, 2020
@ytsarev
Copy link
Member

ytsarev commented Apr 27, 2020

@kuritka just a nitpick, please github special keywords to reference the associated Issue in future. It will autoclose the issue after the merge.
Also specifying issue number in header will result in 'Failover demo(#69) #103 ' where it is not immediately clear what is issue number and what is PR number.
I've fixed the title and PR comment so above recommendations are for the future. Merging in

@ytsarev ytsarev merged commit e2b63de into master Apr 27, 2020
@ytsarev ytsarev deleted the #69_failover branch April 27, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend documentation with end-to-end application deployment scenario
2 participants