New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Saturating / UniqueSaturatedFrom / UniqueSaturatedInto to simplify code #42

Closed

xlc opened this issue Dec 18, 2019 · 1 comment

Member

xlc commented Dec 18, 2019 •

edited

Loading

Review the code and do following changes:

Change x.unwrap_or(0.into)
- To x.unwrap_or_default()
Change let x = TryInto::<u128>::try_into(x).unwrap_or(Bounded::max_value());
- To let x: u128 = x.unique_saturated_into();
Change x.checked_mul(&y).unwrap_or(Bounded::max_value())
- To x. saturating_mul(y)
Same for checked_div / checked_add / checked_sub / checked_mul_int

Relates: #41

The text was updated successfully, but these errors were encountered:

wangjj9219 mentioned this issue

simplify code #43

Merged

Member Author

xlc commented Dec 23, 2019

Fixed by #43

xlc closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment