Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear/Broken Blacklist implementation #156

Closed
jakobwgnr opened this issue Feb 5, 2019 · 2 comments · Fixed by #252
Closed

Unclear/Broken Blacklist implementation #156

jakobwgnr opened this issue Feb 5, 2019 · 2 comments · Fixed by #252
Assignees
@mmacai
Milestone
2.4.0

Comments

@jakobwgnr
Copy link
Contributor

As discovered during analysis for #96 it seems like the implementation of the "Blacklist" feature is unclear or even broken.

It seems like the module RigAuth.Blacklist is not being used anywhere.

Details should be analysed with that issue.
@jakobwgnr jakobwgnr mentioned this issue Feb 5, 2019
Closed
@kevinbader
Copy link
Contributor

kevinbader commented Feb 5, 2019 •
edited

Just to clarify, the feature is definitely not broken. However, there seems to be some dead code leftover after the feature has been refactored a few months back.

@kevinbader kevinbader added this to the 2.2.0 milestone Feb 13, 2019
@mmacai
Copy link
Collaborator

mmacai commented Jun 20, 2019

As a side note, update of documentation with Blacklist functionality should be part of this.

@mmacai mmacai self-assigned this Jul 11, 2019
This was referenced Aug 28, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmacai mmacai

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Kill umbrella Accenture/reactive-interaction-gateway
3 participants
@kevinbader @mmacai @jakobwgnr