Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(source-convert): add support for api version in source convert #884

Merged
merged 8 commits into from
Mar 9, 2022

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Mar 9, 2022

Description

Update source convert to support api versions. This allows for artifacts built with different api version to be deployable

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

aly76
aly76 previously approved these changes Mar 9, 2022
aly76
aly76 previously approved these changes Mar 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #884 (dd91644) into develop (7fa9259) will increase coverage by 1.27%.
The diff coverage is 59.75%.

❗ Current head dd91644 differs from pull request most recent head 794201a. Consider uploading reports for the commit 794201a to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #884      +/-   ##
===========================================
+ Coverage    64.34%   65.62%   +1.27%     
===========================================
  Files           49       48       -1     
  Lines         1593     1533      -60     
  Branches       355      336      -19     
===========================================
- Hits          1025     1006      -19     
+ Misses         568      527      -41     
Impacted Files Coverage Δ
...ages/core/src/artifacts/ArtifactFilePathFetcher.ts 34.04% <0.00%> (+3.56%) ⬆️
...org/packageQuery/InstalledPackagesQueryExecutor.ts 40.00% <ø> (ø)
packages/core/src/package/SFPPackage.ts 84.93% <ø> (ø)
packages/core/src/org/SFPOrg.ts 56.06% <56.06%> (ø)
packages/core/src/utils/ObjectCRUDHelper.ts 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d3f12...794201a. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working refactor
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants