Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat(pool): Add an option to Pool Configuration for scratch org creation time #903

Merged
merged 6 commits into from
Mar 24, 2022

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Mar 23, 2022

Description

Add wait time as an addition parameter in pool config, Fixes #818

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

Add waitTime as an optional config in pool defintion. This allows the command to wait for longer to
create scratch orgs,as scratch orgs often created from shape take a considerable time

fix #818
@codecov-commenter
Copy link

Codecov Report

Merging #903 (5831db8) into develop (93f70ad) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #903      +/-   ##
===========================================
+ Coverage    80.05%   80.07%   +0.01%     
===========================================
  Files           36       36              
  Lines         1103     1104       +1     
  Branches       234      234              
===========================================
+ Hits           883      884       +1     
  Misses         220      220              
Impacted Files Coverage Δ
packages/core/src/package/SFPPackage.ts 85.13% <ø> (ø)
packages/core/src/package/PackageManifest.ts 93.57% <100.00%> (ø)
packages/core/src/project/ProjectConfig.ts 88.88% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4ea28...5831db8. Read the comment docs.

@azlam-abdulsalam azlam-abdulsalam changed the title feat/scratchorg creation wait Add an option to Pool Configuration for scratch org creation time Mar 23, 2022
@jonathankretzmer
Copy link
Contributor

Excited about this fix, thanks @azlam-abdulsalam

@azlam-abdulsalam azlam-abdulsalam changed the title Add an option to Pool Configuration for scratch org creation time feat(poool): Add an option to Pool Configuration for scratch org creation time Mar 24, 2022
@azlam-abdulsalam azlam-abdulsalam changed the title feat(poool): Add an option to Pool Configuration for scratch org creation time feat(pool): Add an option to Pool Configuration for scratch org creation time Mar 24, 2022
@azlam-abdulsalam azlam-abdulsalam merged commit 5ce4033 into develop Mar 24, 2022
@azlam-abdulsalam azlam-abdulsalam deleted the feat/scratchorg-creation-wait branch March 24, 2022 02:07
@azlam-abdulsalam azlam-abdulsalam self-assigned this Mar 30, 2022
@azlam-abdulsalam azlam-abdulsalam added the enhancement enhancement to existing feature label Mar 30, 2022
@azlam-abdulsalam azlam-abdulsalam added this to the Release - April 2022 milestone Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants