Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

fix(schema): Remove unsupported entities #921

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Apr 5, 2022

Description

Remove not supported entities from sfdx-project.json schema, such as

  • postInstallScript
  • uninstallScript
  • unpackagedMetadata

These will be reintroduced at a later stage, when sfpowerscripts support it.

Workarounds:

  • For postInstallScript utilize postDeploymentScript
  • uninstallScript not currently supported
  • unpackagedMetadata not currently supported

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

@azlam-abdulsalam azlam-abdulsalam added this to the Release - April 2022 milestone Apr 5, 2022
@azlam-abdulsalam azlam-abdulsalam added the bug Something isn't working label Apr 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #921 (e6d53a8) into develop (ccd0e79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #921   +/-   ##
========================================
  Coverage    80.16%   80.16%           
========================================
  Files           36       36           
  Lines         1104     1104           
  Branches       238      238           
========================================
  Hits           885      885           
  Misses         209      209           
  Partials        10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd0e79...e6d53a8. Read the comment docs.

@yippie
Copy link

yippie commented May 23, 2022

Can we please immediately undo this. This change is effectively BLOCKING native salesforce package features for no reason. I believe sfpowerscripts simply calls force:package:version:create in the backend which means these tags WERE supported fully and removing them is literally blocking a native salesforce feature for no reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants