Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set INTERFACE_INCLUDE_DIRECTORIES in CMake config #379

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

mwcampbell
Copy link
Contributor

The Meson build system needs this in order to find the header file. I encountered this problem while working on integrating AccessKit into GTK. Our current build system may not work for distro packagers, but this fix at least lets me make progress on that project, and may also help other users.

Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a result it looks like calling include_directories inside the build process of our examples is not necessary anymore. Can you please remove these?

The main README will also need updating.

@mwcampbell
Copy link
Contributor Author

@DataTriny Thanks for adding the changes you suggested. Looks like this is ready to merge.

@mwcampbell mwcampbell merged commit 2b52701 into main Apr 14, 2024
10 checks passed
@mwcampbell mwcampbell deleted the cmake-expose-include-dir branch April 14, 2024 16:49
@mwcampbell mwcampbell mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants