Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using getCanonicalId() instead of getSourceId() for drafts #202

Closed
sfsmfc opened this issue Sep 15, 2021 · 2 comments
Closed

Using getCanonicalId() instead of getSourceId() for drafts #202

sfsmfc opened this issue Sep 15, 2021 · 2 comments
Assignees
@sidedwards

Comments

@sfsmfc
Copy link

sfsmfc commented Sep 15, 2021

Removing deprecation messages for using getSourceId in Craft CMS until version 3.7.x by using getCanonicalId instead.

see also Pull-Request: #201
@ifrimere
Copy link
Contributor

@sfsmfc - thank you for reporting this issue. We will have this issue addressed in v2.0 of the plugin due out by end of the month. I think the issue is actually already resolved in a WIP PR that is under QA right now. fyi @shnsumit @sidedwards

@sidedwards
Copy link
Collaborator

Closing; this was addressed in #184

@sidedwards sidedwards mentioned this issue Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sidedwards sidedwards

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sfsmfc @sidedwards @ifrimere