Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

fix: Dialog 对话框关闭按钮位置错误 #196

Merged
merged 7 commits into from
Dec 7, 2022
Merged

fix: Dialog 对话框关闭按钮位置错误 #196

merged 7 commits into from
Dec 7, 2022

Conversation

sangyuxiaowu
Copy link
Contributor

本次提交包含什么范围

  • [fix] Dialog 对话框层级问题导致的关闭按钮位置错误

关联的 ISSUE 编号

#185

@teacher-zhou teacher-zhou changed the title [修复] Dialog 对话框关闭按钮位置错误 fix: Dialog 对话框关闭按钮位置错误 Dec 7, 2022
@teacher-zhou teacher-zhou self-requested a review December 7, 2022 02:42
@teacher-zhou teacher-zhou linked an issue Dec 7, 2022 that may be closed by this pull request
6 tasks
@pull-request-quantifier-deprecated

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +6 -5
Percentile : 4.4%

Total files changed: 1

Change summary by file extension:
.cs : +6 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@teacher-zhou teacher-zhou merged commit ef4bab4 into tdesign-blazor:master Dec 7, 2022
@sangyuxiaowu sangyuxiaowu deleted the bugfix/component/dialog branch March 3, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[缺陷] Dialog 对话框关闭按钮位置异常
2 participants