New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Swift 3 #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename RegionState to RegionEvent
public enum LocationError: ErrorType { | ||
case LocationError(CLError) | ||
public enum LocationError: Error { | ||
case locationError(CLError.Code) | ||
} | ||
|
||
public enum RegionState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasnt changed in this PR, but I think this enum represents a RegionEvent
, not a RegionState
. Maybe now is a good time to make this breaking change?
Now uses dependency to ReactiveSwift 1.0.0-alpha.1 as it's the only ReactiveSwift version that is available in the Cocoapods master repo. Should be fixed when final version is released.