Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Suggestion) Inpaint with regular ksamplers #670

Closed
RadioVs opened this issue Apr 29, 2024 · 2 comments
Closed

(Suggestion) Inpaint with regular ksamplers #670

RadioVs opened this issue Apr 29, 2024 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@RadioVs
Copy link

RadioVs commented Apr 29, 2024

Lightning models are fixed at 4-8 steps of the loras baked into them, and in advanced ksamplers the denoise is regulated by the start_at_steps, so with low denoise the quality drops noticeably. It would be better to use a regular ksampler with a constant number of steps. Even for other models.

@Acly Acly added the duplicate This issue or pull request already exists label May 1, 2024
@Acly
Copy link
Owner

Acly commented May 1, 2024

There's some discussion about this in #483

I don't know a good solution to make img2img work well with Lightning models. What you're suggesting is not different from increasing total steps. For example running 8-step lightning model at 50% denoise with 16 total steps -> results in 8 actual steps. Doesn't actually look good though in my experience, the noise schedule is too diferent from what Lightning was trained on.

It helps a bit to use a uniform scheduler (not Karras).

@Acly Acly closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
@rbfbatx
Copy link

rbfbatx commented May 2, 2024

I use the lightening models at 45 and they look pretty good especially after a couple of passes but literally go back to that noisy hazy quality at 40 or 50 or any other level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants