Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid browser detection for app launch #264

Open
PeterOrneholm opened this issue Jun 2, 2020 · 0 comments
Open

Avoid browser detection for app launch #264

PeterOrneholm opened this issue Jun 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@PeterOrneholm
Copy link
Member

Is your feature request related to a problem? Please describe.
If possible, we should avoid doing browser detection for these features:

  • DeviceWillReloadPageOnReturnFromBankIdApp
  • DeviceMightRequireUserInteractionToLaunchBankIdApp

Based on testing, we use them today to use different behaviour for launching / returning to the website. This work on most of our browsers, but browsers we haven't tested with / browsers that can't be detected (like Brave) might get the wrong flow.

Also, Safari on iPad Pro will identify as Safari on MacOS, and will therefore get wrong behavior.

Regarding DeviceWillReloadPageOnReturnFromBankIdApp: This only applies to Safari on iOS at the moment, but other browsers might have this behaviour if the tab is deallocated. And Safari on iOS might not have this behaviour if run side by side with BankID on an iPad...

It works in (probably) 99/100 times with the current solution, but if we could redesign it to avoid this detection it would make for a better solution.

What area is it related to
BankID

Describe the solution you'd like

  • Always continue to check status, and persist state info in local storage to handle both when tab reloads and when it don't.
  • Always try to auto launch app, and show user interaction button after some time.
@PeterOrneholm PeterOrneholm added the enhancement New feature or request label Jun 2, 2020
@PeterOrneholm PeterOrneholm added this to the 5.0.0 milestone Jun 2, 2020
@PeterOrneholm PeterOrneholm removed this from the 5.0.0 milestone Jan 17, 2022
@PeterOrneholm PeterOrneholm added this to the 7.0.0 milestone Dec 2, 2022
@PeterOrneholm PeterOrneholm modified the milestones: 7.0.0, 8.0.0 Apr 24, 2023
@PeterOrneholm PeterOrneholm modified the milestones: 8.0.0, 9.0.0 Dec 19, 2023
@PeterOrneholm PeterOrneholm removed this from the 9.0.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant