Missing Task Details duration and end Date attributes

[davidcanonieto]

The current Task Details Model lacks duration and end date. It can be achieved by combining other attributes but this might lead to further confusion and complication.

[salaboy]

this was solved . by the history service, now the Query service should provide this information: https://github.com/Activiti/Activiti/blob/develop/activiti-engine/src/main/java/org/activiti/engine/history/HistoricTaskInstance.java#L37

Due the task basic entity doesn't have this information:
https://github.com/Activiti/activiti-api/blob/develop/activiti-api-task-model/src/main/java/org/activiti/api/task/model/Task.java

[miguelruizdev]

Neither the TaskInfo: https://github.com/Activiti/Activiti/blob/develop/activiti-engine/src/main/java/org/activiti/engine/task/TaskInfo.java

[miguelruizdev]

This is what a task looks like today:

{
    "serviceName": "rb-my-app",
    "serviceFullName": "rb-my-app",
    "serviceVersion": "",
    "appName": "default-app",
    "appVersion": "",
    "id": "9446b62c-02bc-11e9-9a5e-0a580a180015",
    "name": "Perform action",
    "createdDate": "2018-12-18T12:00:57.628+0000",
    "priority": 50,
    "processDefinitionId": "ProcessWithVariables:1:12d29ae7-02bc-11e9-9a5e-0a580a180015",
    "processInstanceId": "94468f19-02bc-11e9-9a5e-0a580a180015",
    "status": "CREATED",
    "lastModified": "2018-12-18T12:00:57.628+0000",
    "standAlone": false,
    "_links": {
        "self": {
            "href": "http://query/v1/tasks/9446b62c-02bc-11e9-9a5e-0a580a180015"
        }
    }
}

[miguelruizdev]

Besides the missing fields, there was a difference regarding the date treatment that @davidcanonieto pointed out: the retrieved tasks have Date objects whereas the expected deal with number of milliseconds

[miguelruizdev]

Probably that type conversion should take place on the client side, though

[miguelruizdev]

PRs addressing this issue:

• Add duration and completedDate AlfrescoArchive/activiti-api#67
• Fix long type in duration field AlfrescoArchive/activiti-api#69
• Extend with new fields in core api AlfrescoArchive/activiti-cloud-api#53
• Fix long type in duration field AlfrescoArchive/activiti-cloud-api#54
• Set duration and completedDate of tasks AlfrescoArchive/activiti-cloud-query-service#162
• Create 'aCompletedTaskWithCreationDateAndCompletionDate' method AlfrescoArchive/activiti-cloud-service-common#125
• Add documentation for duration and completedDate of tasks AlfrescoArchive/activiti-cloud-service-common#126

[miguelruizdev]

This are the changes in the acceptance test covering the newly added code: AlfrescoArchive/activiti-cloud-acceptance-scenarios@9b854f7
Only mergeable when the above PRs are merged

[salaboy]

@miguelruizdev the last comment about acceptance tests points to a commit not to a PR.. why is that?

[miguelruizdev]

@salaboy yep, it's the acceptance test covering the added changes across this issue. Should I open the PR even though I know it will fail anyway?

[salaboy]

@miguelruizdev we need a PR to see if it builds or not (compilation errors)

[miguelruizdev]

@salaboy here it is the acceptance tests PR: AlfrescoArchive/activiti-cloud-acceptance-scenarios#106
Changes in the api(s) need to be propagated for it to compile.

[miguelruizdev]

PRs addressing this issue:

• Add duration and completedDate AlfrescoArchive/activiti-api#67
• Fix long type in duration field AlfrescoArchive/activiti-api#69
• Extend with new fields in core api AlfrescoArchive/activiti-cloud-api#53
• Fix long type in duration field AlfrescoArchive/activiti-cloud-api#54
• Set duration and completedDate of tasks AlfrescoArchive/activiti-cloud-query-service#162
• Create 'aCompletedTaskWithCreationDateAndCompletionDate' method AlfrescoArchive/activiti-cloud-service-common#125
• Add documentation for duration and completedDate of tasks AlfrescoArchive/activiti-cloud-service-common#126
• Add acceptance test covering duration and completedDate  AlfrescoArchive/activiti-cloud-acceptance-scenarios#106