Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need POST admin/v1/process-instances/${id}/variables? #2445

Closed
cristianflorescu opened this issue Feb 4, 2019 · 7 comments
Closed
Assignees
Milestone

Comments

@cristianflorescu
Copy link

No description provided.

@cristianflorescu
Copy link
Author

In initial request https://issues.alfresco.com/jira/browse/ACTIVITI-2413
only GET and DEL are requested

@salaboy salaboy added this to the GA milestone Feb 4, 2019
@salaboy salaboy added this to Open in Activiti 7.x via automation Feb 4, 2019
@mauriziovitale
Copy link
Contributor

As discussed with @salaboy we don't need a POST endpoint but just a PUT.
From the Admin UI, a user should be able to update only existing variables but not to create/delete the existing one.

@salaboy
Copy link
Contributor

salaboy commented Feb 4, 2019

@balsarori
Copy link
Member

I think a POST to create a variable is important otherwise it will be not possible for admins to troubleshoot processes that are broken due to a missing variable (i.e. deleted or not created by error).

@salaboy
Copy link
Contributor

salaboy commented Feb 5, 2019

Let's support update for now..
@balsarori can you share an example where creating a new variable will help to solve a problem?

@salaboy
Copy link
Contributor

salaboy commented Feb 8, 2019

@balsarori @mauriziovitale it was decided to use PUT because the implementation now allows you to update variables values only, instead of creating new ones.

@salaboy
Copy link
Contributor

salaboy commented Feb 8, 2019

merged

@salaboy salaboy closed this as completed Feb 8, 2019
Activiti 7.x automation moved this from Open to Closed Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Activiti 7.x
  
Closed
Development

No branches or pull requests

5 participants