New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres condition name mismatch in activiti-cloud-charts/application/requirements.yaml #2581

Closed

igdianov opened this issue Feb 28, 2019 · 3 comments

Milestone

Contributor

igdianov commented Feb 28, 2019 •

edited by ryandawsonuk

The application/requirement.yaml uses postgres.enabled condition:
https://github.com/Activiti/activiti-cloud-charts/blob/7f06387cceb8f17c5c4030a1fe19e761ed1d3ffc/application/requirements.yaml#L19
vs. runtime-bundle/values.yaml uses postgres.enable value key: https://github.com/Activiti/activiti-cloud-charts/blob/7f06387cceb8f17c5c4030a1fe19e761ed1d3ffc/runtime-bundle/values.yaml#L36

This is causes Postgres instance to be always deployed.

The text was updated successfully, but these errors were encountered:

Contributor

ryandawsonuk commented Feb 28, 2019

ah so enabled vs enable - yeah looks like a typo

salaboy added this to the 7.1.0.M1 milestone

ryandawsonuk mentioned this issue

Enhance installation support in activiti cloud for external postgres #2617

Closed

Contributor

ryandawsonuk commented Mar 11, 2019

I would say enabled is clearer. Also https://github.com/helm/charts/search?q=enabled&unscoped_q=enabled wins vs https://github.com/helm/charts/search?q=enable&unscoped_q=enable

Contributor

almerico commented Mar 11, 2019

AlfrescoArchive/activiti-cloud-charts#59

almerico closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment