ExtendedInMemoryUserDetailsManager.java potential problem

[FlyingDutchmanLQY]

activiti-core-common/activiti-spring-identity/src/main/java/org/activiti/core/common/spring/identity/ExtendedInMemoryUserDetailsManager.java

public class ExtendedInMemoryUserDetailsManager extends InMemoryUserDetailsManager {

    private List<String> users = new ArrayList<>();
    private List<String> groups = new ArrayList<>();

    @Override
    public void createUser(UserDetails user) {
        super.createUser(user);
        users.add(user.getUsername());
        groups = user.getAuthorities().stream()
                .filter(x -> (x.getAuthority().contains("GROUP")))
                .map(x -> (x.getAuthority()))
                .collect(Collectors.toList());
    }
     ...
}

This createUser method seems to overwrite the member variable private List<String> groups.
Maybe it should be like below?

groups.addAll(user.getAuthorities().stream()
                .filter(x -> (x.getAuthority().contains("GROUP")))
                .map(x -> (x.getAuthority()))
                .collect(Collectors.toList()));

[balsarori]

Good catch! Feel free to create a PR to fix that. A test for this case can go here here.