Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1250: JPA/Hibernate Removal + General improvements #1253

Merged
merged 5 commits into from Jul 18, 2017

Conversation

salaboy
Copy link
Contributor

@salaboy salaboy commented Jul 16, 2017

Removing JPA/Hibernate dependencies from the spring boot starters and making general formatting and bool == false (unnecessary bool comparisons) improvements.

@codecov
Copy link

codecov bot commented Jul 16, 2017

Codecov Report

Merging #1253 into master will increase coverage by 0.11%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1253      +/-   ##
============================================
+ Coverage     56.66%   56.77%   +0.11%     
+ Complexity     9241     9236       -5     
============================================
  Files          1151     1148       -3     
  Lines         40577    40774     +197     
  Branches       5924     5926       +2     
============================================
+ Hits          22991    23150     +159     
- Misses        14858    14899      +41     
+ Partials       2728     2725       -3
Impacted Files Coverage Δ Complexity Δ
...g/boot/actuate/endpoint/ProcessEngineEndpoint.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...va/org/activiti/model/converter/TaskConverter.java 80% <ø> (+0.83%) 0 <0> (ø) ⬇️
.../src/main/java/org/activiti/client/model/Task.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...del/resources/assembler/TaskResourceAssembler.java 57.14% <ø> (-12.09%) 0 <0> (ø)
...tor/language/json/converter/BpmnJsonConverter.java 82.02% <ø> (+0.5%) 97 <0> (ø) ⬇️
...ti/spring/boot/ProcessEngineAutoConfiguration.java 0% <ø> (ø) 0 <0> (?)
...language/json/converter/BaseBpmnJsonConverter.java 53.3% <ø> (+0.62%) 60 <0> (ø) ⬇️
...ctiviti/spring/boot/EndpointAutoConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...mn/behavior/EventBasedGatewayActivityBehavior.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...java/org/activiti/engine/impl/db/DbSqlSession.java 62.97% <ø> (-0.02%) 148 <0> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa6c57...6920167. Read the comment docs.

@salaboy
Copy link
Contributor Author

salaboy commented Jul 16, 2017

@erdemedeiros @ryandawsonuk feel free to review these changes.. There are a lot of formatting changes so it gets really difficult, but mainly I did the changes regarding boolean comparisons and I've removed the JPA/Hibernate dependency from the starter. If I don't get any review I will just merge this to avoid further conflicts. Both CodeCov and Codacy seems to be happy about the changes :)

@salaboy salaboy merged commit 587d3e1 into master Jul 18, 2017
@salaboy salaboy deleted the general-improvements branch July 18, 2017 06:52
gmalanga added a commit that referenced this pull request Jul 18, 2017
* master:
  Initial IDM/Keycloak integration (#1246)
  #1250: JPA/Hibernate Removal  + General improvements (#1253)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant