This repository has been archived by the owner on Feb 13, 2021. It is now read-only.
feat: Add admin resume process endpoint #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
igdianov
changed the title
igdianov
changed the title
salaboy
reviewed
Nov 14, 2018
| public class ProcessInstanceAdminControllerImplIT { | ||
|
|
||
| private static final String DOCUMENTATION_IDENTIFIER = "process-instance"; | ||
| private static final String DOCUMENTATION_IDENTIFIER = "process-admin"; |
There was a problem hiding this comment.
@almerico can we call this process-instance-admin?
salaboy
reviewed
Nov 14, 2018
| @@ -341,7 +341,7 @@ public void suspendShouldPutProcessInstanceInSuspendedState() { | |||
| assertThat(responseEntity.getStatusCode()).isEqualTo(HttpStatus.OK); | |||
| return responseEntity; | |||
| } | |||
|
|
|||
| //almer | |||
There was a problem hiding this comment.
@almerico can we remove this one?
salaboy
reviewed
Nov 14, 2018
| //testadmin should see process instances at admin endpoint | ||
| keycloakSecurityContextClientRequestInterceptor.setKeycloakTestUser("testadmin"); | ||
| ResponseEntity<Void> responseEntity = adminExecuteRequestSuspendProcess(startProcessEntity); | ||
|
|
There was a problem hiding this comment.
@CTI777 it wouldn't hurt to check that the process instance is SUSPENDED at this point.. just to make sure that the next check after resume (RUNNING) make sense
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Activiti/Activiti#2151