New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add admin resume process endpoint #145

Merged
merged 7 commits into from Nov 14, 2018

Conversation

Projects
None yet
5 participants
@almerico
Member

almerico commented Nov 12, 2018

@almerico almerico self-assigned this Nov 12, 2018

@almerico almerico requested a review from erdemedeiros Nov 12, 2018

@CLAassistant

This comment has been minimized.

CLAassistant commented Nov 12, 2018

CLA assistant check
All committers have signed the CLA.

@igdianov igdianov changed the title from adde Resume endpoint on task admin controller to feat: Add resume endpoint on task admin controller Nov 12, 2018

@igdianov igdianov changed the title from feat: Add resume endpoint on task admin controller to feat: Add admin resume process endpoint Nov 12, 2018

public class ProcessInstanceAdminControllerImplIT {
private static final String DOCUMENTATION_IDENTIFIER = "process-instance";
private static final String DOCUMENTATION_IDENTIFIER = "process-admin";

This comment has been minimized.

@salaboy

salaboy Nov 14, 2018

Member

@almerico can we call this process-instance-admin?

@@ -341,7 +341,7 @@ public void suspendShouldPutProcessInstanceInSuspendedState() {
assertThat(responseEntity.getStatusCode()).isEqualTo(HttpStatus.OK);
return responseEntity;
}
//almer

This comment has been minimized.

@salaboy

salaboy Nov 14, 2018

Member

@almerico can we remove this one?

//testadmin should see process instances at admin endpoint
keycloakSecurityContextClientRequestInterceptor.setKeycloakTestUser("testadmin");
ResponseEntity<Void> responseEntity = adminExecuteRequestSuspendProcess(startProcessEntity);

This comment has been minimized.

@salaboy

salaboy Nov 14, 2018

Member

@CTI777 it wouldn't hurt to check that the process instance is SUSPENDED at this point.. just to make sure that the next check after resume (RUNNING) make sense

This comment has been minimized.

@CTI777

CTI777 Nov 14, 2018

Contributor

Should be implemented

@salaboy salaboy merged commit f6266ec into develop Nov 14, 2018

5 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - pom.xml (Activiti) No new issues
Details

@salaboy salaboy deleted the almerico-2151-admin-resume-process branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment