Fixed Inconsistency in column_type, allow_nulls, recovery_value

[soartec-lab]

Thank you for providing such a great gem.
I created this PR because I ran into one problem while using this gem in my project.

Expect

In case of column type:" boolean " and allow nulls: false, nil should not be stored in the deleted column.

Actual

However, when the recover and recover! methods are used for the object of the class with the following conditions, nil is stored in the deleted column.

class ParanoidBooleanNotNullable < ActiveRecord::Base
  acts_as_paranoid column: "deleted", column_type: "boolean", allow_nulls: false
end

ParanoidBooleanNotNullable.create!
ParanoidBooleanNotNullable.first.destroy
ParanoidBooleanNotNullable.delete_flag # => true
ParanoidBooleanNotNullable.only_deleted.first.recover # => true
ParanoidBooleanNotNullable.delete_flag # => nil 'expected is false'

Changes

Set default value recovery_value to false for case ofcolumn_type:" boolean " and allow_nulls: false.

[mvz]

This makes perfect sense. Can you take a look at the test failures?

[mvz]

Tests are failing because of this line.

[soartec-lab]

I fixed this and committed again.

[soartec-lab]

@mvz

Thank you for your review. It seems that I forgot to delete the library used during development.
I removed this and confirmed that the test was all green.
could you review again?

[soartec-lab]

I'm experiencing some Rubocop Offenses. However, to address this warning, a refactoring that is not significantly involved in this fix is ​​required. I'm thinking of proposing this fix in another PR again after merging this PR.
Is this PR mergeable?

[mvz]

Please don't worry about the RuboCop offenses for now.

[soartec-lab]

Was good. I was relieved.

[soartec-lab]

@mvz
The tests are all green, is this PR ready to merge?
Or do I have anything else to do?

[zhengf2]

Hi @mvz , is there something holding up this PR that needs addressing? We've hit this issue when trying to upgrade to 0.7.2 as well

[mvz]

Thanks for reminding me @zhengf2. I'll check this again this weekend.

[mvz]

Thanks, @soartec-lab!

[mvz]

This change has been released as part of version 0.7.2.