Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: reported version incorrect from website download #661

Open
rkuhn opened this issue Jan 2, 2024 · 1 comment
Open

[Bug]: reported version incorrect from website download #661

rkuhn opened this issue Jan 2, 2024 · 1 comment
Labels

Comments

@rkuhn
Copy link
Member

rkuhn commented Jan 2, 2024

Product

Actyx

Operating System

Mac

Current behavior

Downloaded the 2.18.1 package ax-2.18.1-macos-arm.zip:

rkuhn@rkPro Downloads % ./ax --version
ax 2.18.0-cargo-macos-aarch64-release

Expected behavior

Version should be 2.18.1 and the git hash should be shown instead of cargo.

How to reproduce

No response

Additional notes

No response

@rkuhn rkuhn added the Bug label Jan 2, 2024
@Kelerchian
Copy link
Contributor

There is another issue that may be related:

  1. On release commit detection, when ax product is in new_versions, a version bump is applied to 1.) ax's cargo.toml and ax-core's databank version.
  2. In the case where new_versions does not include ax-core, this step does not bump ax-core's cargo.toml version.
  3. Because of the lack of bump, the next cargo publish on ax on a clean commit/workspace will fail because ax compilation will use the previous version of ax-core instead. Failure happens when DATABANK_VERSION does not match CARGO_PKG_VERSION because DATABANK_VERSION is gotten from the previous version of ax-core.

This issue might be caused by the previous-version-retrieval behavior on step 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants