Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to Minecraft PC Loot tables #10

Open
Thunder33345 opened this issue May 9, 2017 · 18 comments
Open

Switching to Minecraft PC Loot tables #10

Thunder33345 opened this issue May 9, 2017 · 18 comments

Comments

@Thunder33345
Copy link

Basically title; having a similar or same system as mojang current loot table works

The conditions section could get ignored but some basics would be nice

wiki: http://minecraft.gamepedia.com/Loot_table#Tags

low priority but good to take note of and sorted when other higher things get done

@inxomnyaa
Copy link
Collaborator

inxomnyaa commented May 9, 2017

ClearSkyTeam/PocketMine-MP@6ef9e61

Loot table generation/randomisation proven to work here.

This could be imported to this plugin.

@inxomnyaa
Copy link
Collaborator

Those loot tables are actually taken from the MCPE default addon.

@Ad5001
Copy link
Owner

Ad5001 commented May 9, 2017

Btw am I allowed to take this code and adapt it or not?

@inxomnyaa
Copy link
Collaborator

This could be imported to this plugin

@Ad5001 Ad5001 changed the title Better Loot Tables? Switching to Minecraft PC Loot tables May 9, 2017
@Thunder33345
Copy link
Author

Thunder33345 commented May 9, 2017

Btw am I allowed to take this code and adapt it or not?

i dont see anything stopping you like it's already open sourced
but i advise you not to copy it directly due to how it's meant only for fishing with bunch of hotfixes
love the usage of projects FINALLY... Someone used it

@Ad5001
Copy link
Owner

Ad5001 commented May 9, 2017

They are pretty useful by using issues ;)

@inxomnyaa
Copy link
Collaborator

cough assign me

@Ad5001
Copy link
Owner

Ad5001 commented May 13, 2017

@thebigsmileXD Well, I can't until you accept the colaboration.

@inxomnyaa
Copy link
Collaborator

Oh xd i forgot that this is needed

@Ad5001
Copy link
Owner

Ad5001 commented May 13, 2017

@thebigsmileXD Btw when you start working on an issue, Move it in the projects tab ;)

@inxomnyaa
Copy link
Collaborator

kk

@inxomnyaa
Copy link
Collaborator

image

@inxomnyaa
Copy link
Collaborator

image
See the loottables branch

@Thunder33345
Copy link
Author

try to close only after it's merged pull #22 is not merged

@inxomnyaa
Copy link
Collaborator

the problem is the legal part
eula and shit

@Ad5001 Ad5001 moved this from [TODO] to [WIP] in 1.1: The suggestion release. May 14, 2017
@inxomnyaa inxomnyaa reopened this May 16, 2017
@inxomnyaa
Copy link
Collaborator

image
This might take some fucking time

@inxomnyaa
Copy link
Collaborator

inxomnyaa commented May 16, 2017

Nope, fuck this. I will not go through every fucking file and remake all changes

@Ad5001 DIY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants