Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Block ad on this website' does not work on Touch+Mouse devices like Surface #140

Closed
freezewind opened this issue Oct 8, 2017 · 9 comments
Assignees
Labels
Milestone

Comments

@freezewind
Copy link

freezewind commented Oct 8, 2017

Adguard 6.2.424.2123
Windows 10
firefox 54(disable multiprocess)
firefox 55-56

#31
It is the same result with this issues.
In this issues, the firefox 54 is works for me, but it does work again when I update it.
The problem is multiprocess. The 'Block ad on this website' doesn't works when multiprocess enable.
I tested both original build and private builds.
'Block ad on this website' doesn't work in firefox 55 or 56, and I cannot find a way to disable multiprocess in firefox 55 or 56.
PS. 'Block ad on this website' works with touch screen when multiprocess enables. This bug appears with mouse only.

@ameshkov ameshkov added the bug label Oct 9, 2017
@ameshkov ameshkov added this to the 4.0 milestone Oct 9, 2017
@4-life
Copy link
Contributor

4-life commented Oct 10, 2017

Can't reproduce. I think it's not about multiprocess. @ameshkov what do you think?

@freezewind
Copy link
Author

I just install Chrome, and it also doesn't work.
The reason may be not about multiprocess, but my firefox actual doesn't work when multiprocess enable only.
Also, I create a new profiles to test this, so I don't think it related to old profile.

@ameshkov
Copy link
Member

@freezewind
Hm, does not work in Chrome? What if we have a compatibility issue here with some other software or extension?

@freezewind
Copy link
Author

freezewind commented Oct 10, 2017

@ameshkov
Yes, I don't install any extension in Chrome which I just installed for test, and I don't install any antivirus & security software exclusing windows defender.
I test in two computer. One is win10. The other one is win7.
Chrome and firefox with multiprocess don't work in both computers.
In win10, Edge works, but IE 11.15.16299.0 doesn't work with both touching and mouse.
In win7, IE 11.0.9600.18762 works.

@freezewind
Copy link
Author

@ameshkov
If you can not reproduce, you can remotely access my computer. Would it help you to fix this problem?

@ameshkov
Copy link
Member

@freezewind hope so, please email me to am at adguard.com

@ameshkov ameshkov changed the title 'Block ad on this website' not working when Firefox enable multiprocess 'Block ad on this website' does not work on Touch+Mouse devices like Surfact Oct 13, 2017
@ameshkov ameshkov changed the title 'Block ad on this website' does not work on Touch+Mouse devices like Surfact 'Block ad on this website' does not work on Touch+Mouse devices like Surface Oct 13, 2017
@ameshkov
Copy link
Member

@freezewind thanks for helping us!

@4-life I finally understood what was the issue. The thing is that @freezewind has a Surface device with a mouse. It supports BOTH mouse and touch events, but Assistant decides that "touch" is more important and ignores "mouse" events completely. I reckon we should be able to reproduce it on our Lenovo Yoga.

@ameshkov
Copy link
Member

Also, I see a weird error in the browser console (unrelated to this issue, but should be fixed):
Adguard Assistant Beta.user.js:5591 GET https://www.google.com/i/s-wot.png 404 (Not Found)

@freezewind
Copy link
Author

@ameshkov I am happy for helping you to fix this issue.

@4-life 4-life closed this as completed in 7cd8405 Oct 16, 2017
4-life added a commit that referenced this issue Oct 16, 2017
* commit '7cd8405ffcbdf4bcf9e46d4285cc79426ee7eaf4':
  Fix #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants