New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assistant interface for mobile devices #28
Comments
Merged
Unlike the desktop app, the only functionality we need on mobile devices is selecting and blocking an element. So, we need a new simplified API to be used without a script host. var adguardAssistant = (function() {
return {
start: function(callback) {}
}
})();
|
You should also add a sample of the mobile assistant initialization to tests. |
<script src="path_to_mobile_assistant"></script>
<script>
adguardAssistant.start(function(ruleText) {
console.log(ruleText);
});
</script> |
Issues with the current implementation:
|
Merged
4-life
added a commit
that referenced
this issue
Jan 22, 2018
* commit '4fdbe71b6dc54ba0f737bc05ede3ad5986d04fe3': Update locales Merge master. Update shadow dom Fix view Fix view Fix view Fix view Fix view Update Update mobile8 Update Update mobile view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should have a single code-base for mobile devices.
For instance, iOS currently partly reuses assistant's code, it would be much easier if it was re-using it completely.
The text was updated successfully, but these errors were encountered: