Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant interface for mobile devices #28

Closed
ameshkov opened this issue May 8, 2017 · 4 comments
Closed

Assistant interface for mobile devices #28

ameshkov opened this issue May 8, 2017 · 4 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented May 8, 2017

We should have a single code-base for mobile devices.

For instance, iOS currently partly reuses assistant's code, it would be much easier if it was re-using it completely.

@ameshkov ameshkov added this to the 4.2.0 milestone Jul 3, 2017
@kaprielov kaprielov mentioned this issue Jul 5, 2017
@ameshkov
Copy link
Member Author

ameshkov commented Jul 6, 2017

Unlike the desktop app, the only functionality we need on mobile devices is selecting and blocking an element.

So, we need a new simplified API to be used without a script host.

var adguardAssistant = (function() {
    return {
        start: function(callback) {}
    }
})();
  • start starts selecting an element.
  • callback(ruleText) is called when user clicks "Block"

@ameshkov
Copy link
Member Author

ameshkov commented Jul 27, 2017

You should also add a sample of the mobile assistant initialization to tests.

@ameshkov
Copy link
Member Author

ameshkov commented Aug 7, 2017

<script src="path_to_mobile_assistant"></script>
<script>
adguardAssistant.start(function(ruleText) {
    console.log(ruleText);
});
</script>

@ameshkov
Copy link
Member Author

Issues with the current implementation:

  1. There should be no AG button and no settings
  2. Dialog windows are too large

4-life added a commit that referenced this issue Aug 14, 2017
@4-life 4-life mentioned this issue Aug 14, 2017
@4-life 4-life closed this as completed in 707be56 Aug 25, 2017
@ameshkov ameshkov modified the milestones: 4.0, 4.1 Aug 29, 2017
4-life added a commit that referenced this issue Jan 22, 2018
* commit '4fdbe71b6dc54ba0f737bc05ede3ad5986d04fe3':
  Update locales
  Merge master. Update shadow dom
  Fix view
  Fix view
  Fix view
  Fix view
  Fix view
  Update
  Update
  mobile8
  Update
  Update mobile view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants