Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way $network rules work #1645

Closed
ameshkov opened this issue Mar 31, 2017 · 1 comment
Closed

Change the way $network rules work #1645

ameshkov opened this issue Mar 31, 2017 · 1 comment
Assignees
@adbuker
Labels
ad blocking
Milestone
6.2

Comments

@ameshkov
Copy link
Member

Currently, $network is an additional flag we check (and keep those rules in an additional filter).

Instead, we should make $network one of content types, so that we could keep these rules in default filters, and we could easily add other modifiers support ($important, for instance).
@ameshkov ameshkov added this to the 6.1 R3 milestone Mar 31, 2017
@ameshkov ameshkov modified the milestones: 6.2, 6.1 R3 Mar 31, 2017
@adbuker
Copy link

adbuker commented Apr 3, 2017 •
edited

resolved in ADWIN-CR-170

@adbuker adbuker mentioned this issue Apr 3, 2017
Closed
@adbuker adbuker closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adbuker adbuker

Labels
ad blocking
Projects
None yet
Milestone
6.2
Development

No branches or pull requests
2 participants
@ameshkov @adbuker