Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Advanced Settings logic #2915

Closed
adbuker opened this issue Aug 22, 2019 · 1 comment
Closed

Improve the Advanced Settings logic #2915

adbuker opened this issue Aug 22, 2019 · 1 comment

Comments

@adbuker
Copy link

adbuker commented Aug 22, 2019

We must do it in order to distinguish the values selected by AdGuard itself and values, selected by the user.

Related to #2830.

@northis
Copy link
Member

northis commented Nov 6, 2019

Resolved in adguard-windows/pull-requests/683.
How to test:

  1. Use both scenarios - new installation and update from a previous version
  2. Reset the advanced settings. Take a look on environment-depended settings like Filter localhost (depends on whether Sophos installed or not) or Use TLS 1.3 (depends on whether Avast installed or not)
  3. Change these environment condition (install or remove Avast for example) and ensure that the corresponding settings have been changed.
  4. Change one of these settings manually and ensure, that they no longer depends on environment. Resetting sto defaults will make them depend on the environment again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants