Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable autoupdate over Wi-Fi only by default #682

Closed
ameshkov opened this issue Mar 6, 2018 · 3 comments
Closed

Enable autoupdate over Wi-Fi only by default #682

ameshkov opened this issue Mar 6, 2018 · 3 comments
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented Mar 6, 2018

Also, make sure that it works for everything:

  1. Safari filters updates
  2. Privacy subscriptions updates
@ameshkov ameshkov added this to the 2.0.1 milestone Mar 6, 2018
@lancelot-moon
Copy link

lancelot-moon commented Mar 6, 2018

Before I did the request, #663, I ever thought if I should do this request for letting "Auto Update over Wi-Fi only" include the updates of subscriptions.

But I cancelled my thought.
Because users need to manually click "Check for updates", it represents that users have made the decision to update via Wi-Fi or cellular network.

I am not sure the purpose of "Auto Update over Wi-Fi only" in your design.
Is it for those who want to save the data usage of cellular network or for on top of manually updating at any time, automatically updating in the background when using Wi-Fi?

It's still a good idea which lets "Auto Update over Wi-Fi only" include the updates of subscriptions.
Then we only need to add the headline, "For SAFARI CONTENT BLOCKING", and divisional lines for "Use Simplified Filters" and "Invert Whitelist" in Advanced Settings.

And change the description for "Auto Update over Wi-Fi only".
Original: "If this setting is enabled, AdGuard will only use WiFi for background filter updates."
New: "If this setting is enabled, AdGuard will only use Wi-Fi for the auto updates of Safari filters & Privacy Settings' subscriptions in the background, and then automatically or manually updating them via cellular network is not allowed."

--

  1. If the purpose of "Auto Update over Wi-Fi only" in your design is for those who want to save the data usage of cellular network.............

If this setting is enabled, manually updating Safari filters & Privacy Settings' subscriptions via cellular network is not allowed.

We maybe also need to notify users to disable the setting (a pop-up) if they forget enabling "Auto Update over Wi-Fi only" in the past and want to now manually update Safari filters or Privacy Settings' subscriptions via cellular network.

The pop-up of notification:
"If you want to manually check for updates for Safari filters or Privacy Settings' subscriptions via cellular network, you need to disable "Auto Update over Wi-Fi only" in the Advanced Settings."

  1. If the purpose of "Auto Update over Wi-Fi only" in your design is for on top of manually updating at any time, automatically updating in the background when using Wi-Fi.............

The pop-up of notification is unnecessary.
We need to clearly define the description for "Auto Update over Wi-Fi only".
Original: "If this setting is enabled, AdGuard will only use WiFi for background filter updates."
New: "On top of manually updating Safari filters & Privacy Settings' subscriptions via cellular network / Wi-Fi, if this setting is enabled, AdGuard will only use Wi-Fi for their auto updates in the background."

B/R

@lancelot-moon
Copy link

lancelot-moon commented Mar 6, 2018

Honestly, if you let "Auto Update over Wi-Fi only" include not only Safari filters but also Privacy Settings' subscriptions and enable it by default........

Why do you not design AdGuard Pro to automatically update Safari filters & Privacy Settings' subscriptions in the background via cellular network / Wi-Fi by default?
(Don't need to enable "Auto Update over Wi-Fi only" by default.
Only when we want to save the data usage of cellular network, we enable it.)

This is much better than enabling"Auto Update over Wi-Fi only" by default.
In the past, I supposed that you give up auto updates for Safari filters & Privacy Settings' subscriptions due to Apple's policy.

@ameshkov
Copy link
Member Author

ameshkov commented Mar 10, 2018

This is a good idea, @zebrum plz take care of it & create a new task here on GH.

Original: "If this setting is enabled, AdGuard will only use WiFi for background filter updates."
New: "On top of manually updating Safari filters & Privacy Settings' subscriptions via cellular network / Wi-Fi, if this setting is enabled, AdGuard will only use Wi-Fi for their auto updates in the background."

edit: disregard, it is created: #689

@zebrum zebrum closed this as completed Mar 19, 2018
adguard pushed a commit that referenced this issue Feb 4, 2020
…ash_fix to master

* commit '46e8d035cac4f9c848307bfc2d7cd1ef7e8cdba8':
  fixed crash in tunnel with disabled user filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants