Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AbstractMessage.type_constraints #420

Closed
treiher opened this issue Aug 31, 2020 · 1 comment
Closed

Refactor AbstractMessage.type_constraints #420

treiher opened this issue Aug 31, 2020 · 1 comment
Labels
model Related to model package (e.g., model verification) refactoring

Comments

@treiher
Copy link
Collaborator

treiher commented Aug 31, 2020

More than once I wondered what the meaning of the parameter of the type_constraints method is ("Why do I need to pass an expression to get all type constraints of a message?"):

    def type_constraints(self, expression: expr.Expr) -> Sequence[expr.Expr]:

The method should be refactored and/or documented to make their behavior more obvious.

@treiher treiher added the model Related to model package (e.g., model verification) label Aug 31, 2020
@treiher treiher added this to To do in RecordFlux 0.5 via automation Aug 31, 2020
@treiher treiher added this to To do in RecordFlux 0.7 via automation Jan 21, 2021
@treiher treiher removed this from To do in RecordFlux 0.5 Jan 21, 2021
@senier senier removed this from To do in RecordFlux 0.7 Aug 23, 2022
@senier senier added this to To do in RecordFlux Future via automation Aug 23, 2022
@treiher
Copy link
Collaborator Author

treiher commented Dec 5, 2023

Fixed in 7e0a00a.

@treiher treiher closed this as completed Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Related to model package (e.g., model verification) refactoring
Projects
No open projects
Development

No branches or pull requests

2 participants