Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy manifest support #2

Closed
WanftMoon opened this issue Apr 17, 2024 · 9 comments
Closed

Privacy manifest support #2

WanftMoon opened this issue Apr 17, 2024 · 9 comments

Comments

@WanftMoon
Copy link

WanftMoon commented Apr 17, 2024

Hi @AdamEssenmacher was looking for the issues tab on your repo and there is none, so I would like to kindly ask if you plan on updating your bindings to at least 10.22 which is when they introduced the privacy manifest. These are required starting 1st May.
image

Thank you @WanftMoon, I've enabled issues and discussions on the fork so we can track and discuss things over there. I do hope to have 10.22 versions published. 10.16 was latest when I last swept through and updated the fork. In the worst case, it's my understanding that we can take direct control over the privacy manifest.

@AlleSchonWeg yeah that looks like the long file path issue. I don't know if there's anything that can be done about it. Long file paths are a natural part of how XCFrameworks are packed, and Visual Studio just can't handle them. The nugets work on iOS and (last I checked) can work on Windows as long as you dotnet restore from the CLI.

Hey, moving the conversation here.

From what i understood reading Apple docs, third party libraries like firebase need to have their own manifests. Not so sure if just the act of adding the privacy manifest to an app will solve the fact that the firebase library does not have it. Also, i've seen a bunch of the native libraries running and releasing new versions these past few months to meet the deadline.
That makes me think that Apple may do a deep scan (starting 1st may) and check for xcframeworks manifests for new uploads.
also, they named firebase in their list of frameworks that need the privacy policy.

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files
Screenshot 2024-04-17 at 15 25 41

https://developer.apple.com/support/third-party-SDK-requirements/

Screenshot 2024-04-17 at 15 29 51

Whats your take?

@AdamEssenmacher
Copy link
Owner

Thank you @WanftMoon. If the solution is as simple as bumping some versions, this shouldn't be a big problem.

Otherwise... the path ahead might be painful 😬

@WanftMoon
Copy link
Author

Thank you @WanftMoon. If the solution is as simple as bumping some versions, this shouldn't be a big problem.

Otherwise... the path ahead might be painful 😬

Yeah, hopefully

@WanftMoon
Copy link
Author

Hey @AdamEssenmacher any news on the 10.22?

@AdamEssenmacher
Copy link
Owner

10.17 was a harder than ideal, but I'm up to 10.18 and working up there.

These AdamE.* packages are going to be incompatible with any other library that depends on Xamarin.Firebase.iOS.Core, including that barcode scanner. They'll need swap the dependency for AdamE.Firebase.iOS.Core.

@WanftMoon
Copy link
Author

10.17 was a harder than ideal, but I'm up to 10.18 and working up there.

These AdamE.* packages are going to be incompatible with any other library that depends on Xamarin.Firebase.iOS.Core, including that barcode scanner. They'll need swap the dependency for AdamE.Firebase.iOS.Core.

Yeah, i've let them know about your work. In the meanwhile, i'll probably do something similar to ZXing to maui, and do a custom renderer using AVFoundation scanner capabilities

@WanftMoon
Copy link
Author

WanftMoon commented Apr 27, 2024

@AdamEssenmacher

I think 10.22 may not be enough, it seems that the list frameworks need to also be signed.

firebase/firebase-ios-sdk#12238
Screenshot 2024-04-27 at 14 46 21

@AdamEssenmacher
Copy link
Owner

We're up to 10.20. 4 more to go.

@AdamEssenmacher
Copy link
Owner

10.24 packages have been published, which is what we needed I think. Please re-open the issue if you run into troubles related to the privacy manifest requirements.

@WanftMoon
Copy link
Author

10.24 packages have been published, which is what we needed I think. Please re-open the issue if you run into troubles related to the privacy manifest requirements.

Thanks man, you are a beast!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants