Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #100 Added better error messages #102

Merged
merged 1 commit into from Mar 2, 2022

Conversation

AdamKobus
Copy link
Owner

@AdamKobus AdamKobus commented Mar 2, 2022

Changes

Added better error messages to NavStackEntry

Testing

Unit tests + manual testing

Checklist

General

  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Source code and docs

  • Changelog is updated (fixes section for a bug, changes for anything that has been added / modified/ removed)
  • New code is covered by unit tests
  • Added ktdoc and updated README.md if API has changed
  • Made sure that unit tests pass
  • Made sure that ktlintCheck and detekt tasks produce no issues
  • Updated demo app if needed

Reviewer Checklist

  • Library builds
  • Demo app works
  • Changes work as expected
  • Changelog and documentation updates reflect the modification made in this PR

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

1 Message
📖

The following dependencies have later milestone versions:

  • com.android.tools.build:gradle [7.1.0 -> 7.1.2]
    https://developer.android.com/studio/build
  • com.google.dagger:hilt-android [2.40.5 -> 2.41]
    https://github.com/google/dagger
  • com.google.dagger:hilt-android-compiler [2.40.5 -> 2.41]
    https://github.com/google/dagger
  • com.google.dagger:hilt-android-gradle-plugin [2.40.5 -> 2.41]
    https://github.com/google/dagger
  • com.pinterest:ktlint [0.43.2 -> 0.44.0]
    https://github.com/pinterest/ktlint
  • io.mockk:mockk [1.12.2 -> 1.12.3]
    http://mockk.io
  • org.jacoco:org.jacoco.ant [0.8.3 -> 0.8.7]
    http://jacoco.org

Gradle current updates:

  • Gradle: [7.4: UP-TO-DATE]

Generated by 🚫 Danger

@AdamKobus AdamKobus merged commit 6d79233 into develop Mar 2, 2022
@AdamKobus AdamKobus deleted the cn-100_better-error-messages-in-arg-getters branch March 2, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant