Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18 #66

Closed
timB73 opened this issue Jan 22, 2023 · 5 comments
Closed

Support React 18 #66

timB73 opened this issue Jan 22, 2023 · 5 comments
Assignees

Comments

@timB73
Copy link

timB73 commented Jan 22, 2023

Hi, I've just upgraded my project to React 18 and found the dice has broken. Everything works except the value returned on the rollDone callback doesn't match the value of the face of the dice. Any possibility this could get fixed? Thanks.

Edit: it looks like the value being returned is the previous rolled value.

@AdamTyler
Copy link
Owner

@timB73 thanks for the issue writeup. I am planning to update a good portion of dependencies for this project soon as many of them have gone out of date.
I will update React as part of this effort

@AdamTyler AdamTyler self-assigned this Jan 26, 2023
@timB73
Copy link
Author

timB73 commented Jan 27, 2023

That's great news, thank you! I couldn't find any other libraries as good as this.

@josegamboa
Copy link

Hi @AdamTyler ,

Thanks for maintaining this library. Is there any plans for exporting the types for Typescript support?

I would like to use this one on a React18 project, but not sure when will be release React18 support.

Thanks...

@AdamTyler
Copy link
Owner

Support for React 18 has been added and will be available in an upcoming release.

@josegamboa can you create an issue specifically to add Typescript support. I want to add that in an upcoming release

@AdamTyler
Copy link
Owner

React 18 is available as of v2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants