New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build scripts for MARTe2 have scattered magic numbers #21

Open

AdamVStephen opened this issue Oct 28, 2023 · 0 comments

Assignees

Labels

Owner

AdamVStephen commented Oct 28, 2023

There is entropy lying around in respect of the branches that get cloned and the naming of directories cross referenced between different scripts.

e.g. install-source-dependencies.sh contains references to branches 0.3 and 1.3 of OPCUA. However, build-sources.sh hard codes OPCUA_BRANCH=1.3

Clearly the intent is to allow the scripts to work with different bundles of branches.

Recommend refactoring so that (1) collections of environment variables define sets of branches (2) all scripts reference these.

AdamVStephen added the enhancement label

AdamVStephen self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment