Check if the log entry is null

[ChristianGreiner]

The Editor throws an exception when you write an "null"-string in the Write-Method of the logging system.

For example:

Log.Editor.Write(null);

I fixed this by checking if the msg is the IsNullOrEmpty:

// in Log.cs - Line 173
private void Write(LogMessageType type, string msg, object context)
{
      if (string.IsNullOrEmpty(msg)) return;
      ...
}

https://github.com/AdamsLair/duality/blob/master/Duality/Utility/Log/Log.cs#L173

[ilexp]

Distantly related to issue #327.

Your fix should work, but not doing anything on null or empty messages might lead to some debugging confusion. Instead, this might be a more transparent fix:

if (msg == null) msg = "[null message]";

Alternatively, an ArgumentNullException could be thrown in order to alert the developer of the fact that he isn't supposed to pass null as first argument:

if (msg == null) throw new ArgumentNullException("msg");

Not yet sure which variant would be better. Probably the first one though, since a logging operation is usually expected to never throw.

---

Edit: Care to submit a PR on this? It'd be faster and easier if I do this myself, but it would be an opportunity to get to know the PR procedure if you're (or someone else is) interested. You'd basically:

1. Fork Duality on GitHub.
2. Create a new branch (based on master) for your PR on your GitHub Fork.
3. Check out the branch on your machine.
4. Implement the fix in this branch.
5. Commit & Push the branch back to your GitHub fork.
6. Create a new PR from that branch to Duality-master.

[ilexp]

Fixed.