Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for more than 2 splits per node #147

Open
zkldi opened this issue Jun 30, 2023 · 3 comments
Open

Allow for more than 2 splits per node #147

zkldi opened this issue Jun 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@zkldi
Copy link
Contributor

zkldi commented Jun 30, 2023

Is your feature request related to a problem? Please describe.
At the moment, a node can only be split horizontally or vertically once, with a fraction indicating how far apart the two are.

In the scenario where I split horizontally twice, I would love for it to instead split into 3 equally-sized chunks [A | B | C], rather than

[A | [B | C]

Peek 2023-06-30 02-00

Describe alternatives you've considered
We could hack around this by twiddling with fraction values based on the tree as a whole, but it's probably easy enough to migrate into a non-binary tree structure. probably.

Additional context
I'm planning to work on this over the weekend, but making an issue for it just incase this is something you're interested in.

@zkldi zkldi added the enhancement New feature or request label Jun 30, 2023
@Adanos020 Adanos020 linked a pull request Jul 23, 2023 that will close this issue
@Adanos020
Copy link
Owner

Adanos020 commented Jul 23, 2023

Closed by #145

@lvaroqui
Copy link
Contributor

lvaroqui commented Jul 23, 2023

@Adanos020 In my understanding this PR issue is not closed by #145?

This issue wants to allow more than 2 nodes in the tree children.
The PR adds the possibility do disable split in a certain.

@Adanos020
Copy link
Owner

@lvaroqui Oh, you're right. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants