Skip to content
This repository has been archived by the owner on Sep 15, 2020. It is now read-only.

Apparent race between _closePopoverBlurHandler and popoverClosed #56

Open
shaoster opened this issue Dec 13, 2018 · 2 comments
Open

Apparent race between _closePopoverBlurHandler and popoverClosed #56

shaoster opened this issue Dec 13, 2018 · 2 comments

Comments

@shaoster
Copy link
Contributor

shaoster commented Dec 13, 2018

I'm having trouble reproducing this myself with the latest version of this library and chrome 70.0.3538.110, but we have seen stack traces with failures on (null).querySelectorAll.

TypeError: Cannot read property 'querySelectorAll' of null
1
File ---.js line ### col ### in i.value
2
File ---.js line ### col ### in HTMLElement.e._closePopoverBlurHandler
@twokul
Copy link
Contributor

twokul commented Dec 13, 2018

the root cause of the issue if that willDestroyElement is never called causing blur event handler _closePopoverBlurHandler after this._popperElement is null-fied.

I'm not 100% sure why willDestroyElement is not called (confirmed it via running ember s and playing around with demo pages); the hacky fix would be to bail if this._popperElement === null

@shaoster
Copy link
Contributor Author

Leaving this issue opened while we try to actually understand the root cause.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants