Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

Error on visiting documentation pages for horizontal & vertical bars #79

Open
lokeshj opened this issue Feb 23, 2015 · 7 comments
Open
Labels

Comments

@lokeshj
Copy link

lokeshj commented Feb 23, 2015

There is a js error undefined is not a function when visiting these two doc pages:
http://addepar.github.io/ember-charts/#/ember-charts/vertical_bar
http://addepar.github.io/ember-charts/#/ember-charts/horizontal_bar

The example section is not rendered due to the error.

Error stacktrace:
Uncaught TypeError: undefined is not a functionapp.js:3344 (anonymous function)ember.js:4448 ComputedPropertyPrototype.getember.js:1939 getember.js:13928 Ember.Observable.Ember.Mixin.create.getapp.js:3971 (anonymous function)ember.js:4448 ComputedPropertyPrototype.getember.js:1939 getember.js:13928 Ember.Observable.Ember.Mixin.create.getapp.js:3982 (anonymous function)ember.js:4448 ComputedPropertyPrototype.getember.js:1939 getember.js:2018 Ember._getPathember.js:1934 getember.js:13928 Ember.Observable.Ember.Mixin.create.getapp.js:3991 (anonymous function)ember.js:4448 ComputedPropertyPrototype.getember.js:1939 getember.js:13928 Ember.Observable.Ember.Mixin.create.getapp.js:3995 (anonymous function)ember.js:4448 ComputedPropertyPrototype.getember.js:1939 getember.js:13928 Ember.Observable.Ember.Mixin.create.getapp.js:3286 Ember.Charts.ChartComponent.Ember.Component.extend.initember.js:1241 superWrapperember.js:15534 Classember.js:15968 Mixin.create.createember.js:21576 Ember.View.Ember.CoreView.extend.createChildViewember.js:22099 Ember.merge.appendChildember.js:21449 Ember.View.Ember.CoreView.extend.appendChildember.js:25995 EmberHandlebars.ViewHelper.Ember.Object.create.helperember.js:26173 (anonymous function)ember.js:24039 (anonymous function)app.js:32432 anonymoushandlebars.js:2212 (anonymous function)ember.js:20680 Ember.View.Ember.CoreView.extend.renderember.js:19617 Ember.CoreView.Ember.Object.extend._renderToBufferember.js:21254 Ember.View.Ember.CoreView.extend._renderToBufferember.js:1241 superWrapperember.js:19598 (anonymous function)ember.js:1685 Ember.Instrumentation.instrumentember.js:19597 Ember.CoreView.Ember.Object.extend.renderToBufferember.js:22049 Ember.merge.renderToBufferIfNeededember.js:21261 Ember.View.Ember.CoreView.extend.renderToBufferIfNeededember.js:22701 Ember.merge.ensureChildrenAreInDOMember.js:22666 Ember.ContainerView.Ember.View.extend._ensureChildrenAreInDOMember.js:5486 DeferredActionQueues.flushember.js:5575 Backburner.endember.js:5614 Backburner.runember.js:5974 Ember.runember.js:19378 Ember.EventDispatcher.Ember.Object.extend._bubbleEventember.js:19322 (anonymous function)ember.js:578 Ember.handleErrorsember.js:19313 (anonymous function)jquery.js:3074 jQuery.event.dispatchjquery.js:2750 elemData.handle

@dylnuge dylnuge added the bug label Feb 24, 2015
@dylnuge
Copy link
Contributor

dylnuge commented Feb 24, 2015

Thanks for reporting this @lokeshj! I'll look into it as soon as I can.

@ghost
Copy link

ghost commented Feb 25, 2015

@lokeshj @dylnuge Not sure if the URL was pasted incorrectly, but the URLs to those pages should actually be:

Instead of:

Correcting the URL yields the fully rendered example page in all of its glory. 👍

@dylnuge
Copy link
Contributor

dylnuge commented Feb 25, 2015

@karelvuong Actually, the second set of URLs you linked are the right ones; the first URLs are from an old build of the documentation and aren't currently up-to-date. We should take those down to avoid confusion though.

@lokeshj
Copy link
Author

lokeshj commented Feb 26, 2015

Please update the link to documentation in the ReadMe as well. I was only following the Readme.

@karelvuong Thanks!

@dylnuge
Copy link
Contributor

dylnuge commented Feb 26, 2015

The readme links (and @lokeshj's original links) are the correct documentation links, sorry that this is so confusing. @karelvuong's first set of links are the ones from the old build.

This is a real bug and it's fixed by #80. Thanks for reporting it!

@dylnuge dylnuge closed this as completed Mar 2, 2015
@dylnuge dylnuge reopened this Mar 2, 2015
@dylnuge
Copy link
Contributor

dylnuge commented Mar 2, 2015

The bug causing this is fixed, but I'm leaving the issue open until I re-deploy the docs.

@artych
Copy link

artych commented Aug 3, 2015

Now it doesn't work again.

 Uncaught TypeError: data.sortBy is not a function

It's interesting that forked and locally grunt compiled version works without error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants