You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #211 (related issue: #212), the behaviour of setting a role of button on links with no href attribute was added. However; when using the hrefBuilder prop, any page links will have an href, and should not take on the role of button.
I'm happy to tackle a PR for this, however I just wanted to check the following couple of things:
Is this a PR you even want?
What would your expected behaviour be?
Initially, my assumption would be that essentially we want something like this (hastily written pseudo-code), where we only assign the role of button if the hrefBuilder prop isn't defined:
In #211 (related issue: #212), the behaviour of setting a role of
button
on links with nohref
attribute was added. However; when using thehrefBuilder
prop, any page links will have anhref
, and should not take on the role of button.I'm happy to tackle a PR for this, however I just wanted to check the following couple of things:
Initially, my assumption would be that essentially we want something like this (hastily written pseudo-code), where we only assign the role of
button
if thehrefBuilder
prop isn't defined:The text was updated successfully, but these errors were encountered: