Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edns-client-subnet (ECS) support #1091

Closed
FenghenHome opened this issue Oct 19, 2019 · 5 comments
Closed

edns-client-subnet (ECS) support #1091

FenghenHome opened this issue Oct 19, 2019 · 5 comments

Comments

@FenghenHome
Copy link

AdGuardHome is a great dns, I really like it.
But I have a problem, I use my vps to create a public dns, AdGuardHome's edns-client-subnet has a problem, AdGuardHome will pass the vps ip address subnet to the upstream resolution, instead of passing my home ip address subnet to the upstream Parsing, so the ip parsed out is very far away from me.

@FenghenHome
Copy link
Author

Of course, there is another problem. When AdGuardHome starts dns cache, ecs does not work.

@ameshkov
Copy link
Member

Yeah, there are basically two different issues:

  1. Set ECS extension to the client IP address
  2. Handle ECS in the response and use it as a cache key

Both can be solved, of course.

@FenghenHome
Copy link
Author

Thank you very much, I really look forward to it.

@ameshkov ameshkov modified the milestones: v0.101, v0.100 Nov 12, 2019
@AngelFalse
Copy link

I suggest adding a switch to let user choose whether to opt-in this feature. There are certain privacy-focusing users that dislike the idea of ECS

@ameshkov
Copy link
Member

Sure, it will be disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants