Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuardHome won't automatic use the latest certificate when user renew their certificate #1142

Closed
3 tasks done
a962702 opened this issue Nov 1, 2019 · 3 comments
Closed
3 tasks done
Labels

Comments

@a962702
Copy link

a962702 commented Nov 1, 2019

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version

  • I checked the documentation and found no answer

  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • v0.99.2
  • How did you setup DNS configuration:
    • Router
  • If it's a router or IoT, please write device model:
    • TL-WDR4300
  • Operating system and version:
    • OpenWrt 18.06.4

Expected Behavior

When user renew their certificate, AdGuardHome Should automatic use the latest certificate.

Actual Behavior

AdGuardHome still use the old certificate.
User need to login WebUI, go to Encryption settings and click save config to use the latest certificate.

Screenshots

Screenshot:

issue
issue2

Additional Information

Also, it seems when I have multiple domains, the domains will display continuous without separation.

@ameshkov
Copy link
Member

ameshkov commented Nov 1, 2019

Yeah, I guess we need to implement some sort of a "file watcher" that will monitor changes to the certificate/key files and update encryption settings automatically.

@szolin
Copy link
Contributor

szolin commented Feb 18, 2020

Isn't it better if admin can signal that certificates may have changed via 'reload' command? - #1302
Automatically updating certificate whenever its date changes may be dangerous (insecure), while, on the other hand, 'reload' command issued by admin explicitly confirms his intention.

@ameshkov
Copy link
Member

Yeah, I guess you're right.

Once reload is ready, we should update the Wiki article with this info and provide an example of a script that does all this:
#1420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants