Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digit grouping ("thousands separator") for numbers on the dashboard #1423

Closed
jandillmann opened this issue Feb 21, 2020 · 1 comment
Closed

Comments

@jandillmann
Copy link

Problem Description

This is a purely cosmetic feature request, but one that would add to the nice and modern look of the dashboard.

Currently numbers on the dashboard are displayed without any kind of formatting (neither in the cards up top nor in the tables below, except for percentages with two decimal places separated by a period).

For example, the top left card shows 123456 DNS Queries. Especially for longer retention times these numbers get large and are not as readable as they could be.

Proposed Solution

Format numbers on the dashboard using decimal grouping. Because the percentages already use a decimal point a comma could be used to group thousands (US-Style).

For example, the number from above could be formatted as 123,456 DNS Queries.

Alternatives Considered

A space character would also increase the readability without confusing Europeans, who use the comma and period the opposite way.

The number from above could be formatted as 123 456 DNS Queries.

@ameshkov
Copy link
Member

ameshkov commented Feb 21, 2020

@IldarKamalov this should be trivial, use locale-specific formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants