Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory allocations on enabling/disabling large filter lists #1463

Closed
ameshkov opened this issue Mar 10, 2020 · 1 comment
Closed

Memory allocations on enabling/disabling large filter lists #1463

ameshkov opened this issue Mar 10, 2020 · 1 comment
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

It seems that we're allocating too much memory when filter lists are enabled, disabled, or updated.

The problem is that golang does not "like" to free memory so we end up with high RSS. Ideally, we'd better avoid allocations whenever it's possible.

@szolin
Copy link
Contributor

szolin commented Mar 11, 2020

Maybe it's time for us to use Last-Modified HTTP header so we won't download any data unless the filter has been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants