Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Client settings' do not allow using IPv6 CIDR #1479

Closed
3 tasks done
DandelionSprout opened this issue Mar 15, 2020 · 0 comments
Closed
3 tasks done

'Client settings' do not allow using IPv6 CIDR #1479

DandelionSprout opened this issue Mar 15, 2020 · 0 comments
Assignees
Milestone

Comments

@DandelionSprout
Copy link
Member

DandelionSprout commented Mar 15, 2020

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version (v0.101.0)
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

The text box at Client settings → Add client → Identifier, refuse to acknowledge IPv6 CIDR addresses and throws up an error message, as seen in the screenshot below. This applies to all regular and irregular IPv6 CIDR formats that I'm aware of at the time of writing, including:

  • 1234:1234:1234:1234:0:0:0:0/64

  • 1234:1234:1234:1234:0000:0000:0000:0000/64

  • 1234:1234:1234:1234::/64

  • [1234:1234:1234:1234:0:0:0:0]/64

  • [1234:1234:1234:1234:0:0:0:0/64]

  • 2001:610::/29 (Which is an actively used entry that 'Disallowed clients' has no problems with, but which 'Client settings' don't allow.)

  • Version of AdGuard Home server:

    • v0.101.0
  • How did you setup DNS configuration:

    • N/A
  • If it's a router or IoT, please write device model:

    • Raspberry Pi 4
  • Operating system and version:

    • N/A

Expected Behavior

IPv6 CIDRs are saveable as a client identifier, the same way IPv4 CIDRs and singular IPv6 IPs always have been.

Actual Behavior

An error note saying "Invalid client ID format" shows up under the textbox, and the Save button doesn't work.

Screenshots

Screenshot:

image

Additional Information

None that feels important for me to explain at the time of writing.

@ameshkov ameshkov added this to the v0.102 milestone Mar 16, 2020
@szolin szolin assigned IldarKamalov and unassigned szolin Mar 16, 2020
@ameshkov ameshkov added the UI label Apr 7, 2020
@ameshkov ameshkov assigned ArtemBaskal and unassigned IldarKamalov Apr 7, 2020
@adguard adguard closed this as completed in bcbffd9 Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants