Client Setting request counter doesn't work when using CIDR for the IP

[bruvv]

Issue Details

• Version of AdGuard Home server:
  v0.105.2
• How did you install AdGuard Home:
  Docker (https://github.com/Freekers/ansible-adguard)

Expected Behavior

When filling in the identifier field the IP
89.205.224.0/24
I assume that it does: 89.205.224.*
and therefor count all the requests that matches the above wildcard IP. But that doesn't work and the counter becomes 0.

I tried:
89.205.224.1/24
But that doesn't work either.

Actual Behavior

It doesn't count any requests in the client settings page. Only when filling in the complete IP it does count as can be seen in the screenshots below:

Screenshots

[ainar-g]

Hi, thank you for your report. What exactly do you mean by “doesn't work”? Do you only mean the request count and statistics or something else?

[bruvv]

Sorry I should clarify. As can bee seen in the screenshots, the request counter doesn't count in the Client settings page.

[ainar-g]

It's clearer now, thanks. We cannot reproduce the issue on our machines. Could you please add the following information:

1. Did you reset statistics between removing the IP and adding the CIDR? If so, are you sure there were actually requests from that IP address?
2. Is IP anonymisation enabled?
3. Which browser are you using? Are there any errors in your browser's console?
4. Can you configure AdGuard Home to collect verbose logs and see if there are any statistics-related errors? Perhaps attach a log here?

Thanks!

[bruvv]

1. I did not reset the statistics. I am also not removing the ip, just editting it, in the "edit client" window.
2. No
3. I have used Edge, chrome and firefox
4. Here you go: https://pastebin.com/Vpqn2pW4 booted, changed the ip to a CIDR ip and then exited the docker again.

I am running this all on a oracle cloud server btw. If that is of any use.

[ainar-g]

Thanks for the data! We'll look into it further.

[bruvv]

Maybe another way to investigate:
When I go to the query log and fill in:
"89.205.224.0/24"
It also doesn't show anything

[EugeneOne1]

@bruvv, hello again and apologies for a continuous idle on the issue. Could you please help us a bit more? We've made lots of changes during v0.107.0 cycle, including clients handling and enhanced logging. Could you please try one of the latest builds, either the release one, or the ones from edge/beta channels? If the issue reproduces there, could you please collect the verbose log once again?

[bruvv]

Still not working on v0.107.0 When searching for a client using CIDR:

[EugeneOne1]

@bruvv, I see. And what about the requests counter on the Clients page? Does it sums all the requests of users contained by the subnet?

[bruvv]

Hi @EugeneOne1 that is a negative:

[EugeneOne1]

@bruvv, well, we're already working on it. Would you mind collecting verbose log once again? I'd be really helpful. Thanks.

[ainar-g]

I should add that the query log search one will probably not work until we revamp the search engine there. But the client counter on the “Clients” definitely needs a fix.

[bruvv]

and here is the verbose @EugeneOne1:
https://pastebin.com/nH0f36tw

[EugeneOne1]

@bruvv, unforunately, we still can't reproduce the behavior. However, we're planning a massive refactoring around v0.108.0 including the rework on statistics module that should improve it's stability. Perhaps that will help.