Fix unsupported regex for QQ blocked rules #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameshkov
approved these changes
Oct 8, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can it be merged? |
|
Apologies for the late response! We'll review and commit this shortly. |
adguard
pushed a commit
that referenced
this pull request
Mar 7, 2022
Updates #3717. * commit 'ded9842cd7fbbae0c3a55cd1f468ade22cab0d97': Fix unsupported regex for QQ blocked rules
|
Thank you for your contribution and again, apologies. This will be available in the next beta, v0.108.0-b.5, as well as the next bugfix release, v0.107.6. |
|
You are welcome. and thank you for such an awesome project. |
adguard
pushed a commit
that referenced
this pull request
Mar 23, 2022
Merge in DNS/adguard-home from qq-rule to master Updates #3717. Squashed commit of the following: commit 1e2d500 Merge: 7290a1c b16b1d1 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed Mar 23 14:14:10 2022 +0300 Merge branch 'master' into qq-rule commit 7290a1c Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Mar 18 20:36:17 2022 +0300 filtering: fix qq regex legacy
adguard
pushed a commit
that referenced
this pull request
Apr 6, 2022
Updates #3717. * commit 'ded9842cd7fbbae0c3a55cd1f468ade22cab0d97': Fix unsupported regex for QQ blocked rules
adguard
pushed a commit
that referenced
this pull request
Apr 6, 2022
Merge in DNS/adguard-home from qq-rule to master Updates #3717. Squashed commit of the following: commit 1e2d500 Merge: 7290a1c b16b1d1 Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Wed Mar 23 14:14:10 2022 +0300 Merge branch 'master' into qq-rule commit 7290a1c Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Mar 18 20:36:17 2022 +0300 filtering: fix qq regex legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source rule uses regex that Golang doesn't support and is now changed to a normal rule.